Skip to content

don't use jsx syntax#5127

Merged
adhami3310 merged 18 commits intomainfrom
don't-use-jsx-syntax
May 7, 2025
Merged

don't use jsx syntax#5127
adhami3310 merged 18 commits intomainfrom
don't-use-jsx-syntax

Conversation

@adhami3310
Copy link
Copy Markdown
Member

No description provided.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 14, 2025

CodSpeed Performance Report

Merging #5127 will improve performances by 3.71%

Comparing don't-use-jsx-syntax (469e270) with main (0e60a47)

Summary

⚡ 1 improvements
✅ 7 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_compile_page[_complicated_page] 117.9 ms 113.7 ms +3.71%

@itsmeadarsh2008
Copy link
Copy Markdown
Contributor

What about renaming the files to *.jsx?

@adhami3310
Copy link
Copy Markdown
Member Author

What about renaming the files to *.jsx?

The issue is not that particularly. It's that JSX is rather oriented towards user-readability which is fairly very low on the things we care about on computer generated code.

The strong reason for moving away from JSX is that it breaks JS into two lands, JSX and JS, and we have to have interactions between the two very carefully. If there's no division between the two then code gets a bit easier to maintain.

@adhami3310 adhami3310 merged commit d65cf69 into main May 7, 2025
42 checks passed
@adhami3310 adhami3310 deleted the don't-use-jsx-syntax branch May 7, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants